Ethereal-dev: Re: [Ethereal-dev] COTP TSAP fields

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Sun, 23 May 2004 16:11:04 -0700
On Fri, May 14, 2004 at 09:32:26PM +0100, matthew.bradley@xxxxxxxxxxxxx wrote:
> Please find attached a patch for packet-clnp.c. It adds fields for source
> and destination TSAP for COTP.

Checked in.

> Is this solution OK? Are there any better ways of achieving the same end?

I can't think of one that's obviously better, offhand.  One additional
way would be to add a new FT_ value for TSAPs, and have that type
display its value as strings or bytes dependent on the preference
setting and contents of the field, and allow either text strings or byte
strings to be specified as values in filters, but that'd require that
the code to handle that field type know the preference setting, and I
don't know whether the "text strings or byte strings" would be easy to
implement.