Ethereal-dev: Re: [Ethereal-dev] Re: [PATCH] acinclude.m4, configure.in

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Thomas Anders <thomas.anders@xxxxxxxxxxxxx>
Date: Fri, 14 May 2004 13:21:27 +0200
Joerg Mayer wrote:

On Fri, May 14, 2004 at 12:00:57PM +0200, Thomas Anders wrote:

As for further improvements: in case of "--with-krb5=/path/to/dir" we should
look for krb5-config in /path/to/dir/bin (in addition to PATH) and use it.


Can you please let me konw whether the attached patch is OK?


Two objections:
1) I'd generally suggest supplying the directory to AC_PATH_PROG only,
   rather than manipulating the global PATH variable. E.g.:
   AC_PATH_PROG(KRB5_CONFIG, krb5-config, ,$PATH:$krb5_lib/bin)
2) We currently only search for krb5-config if krb5_dir is unset.
   This must be changed, too, obviously.


+Thomas

--
Thomas Anders (thomas.anders at blue-cable.de)