Ethereal-dev: [Ethereal-dev] Re: [PATCH] acinclude.m4, configure.in

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Thomas Anders <thomas.anders@xxxxxxxxxxxxx>
Date: Fri, 14 May 2004 12:00:57 +0200
Joerg Mayer wrote:

On Thu, May 13, 2004 at 03:42:27PM +0200, Thomas Anders wrote:

There's still room for "--with-krb5" improvement, though. We currently
depend on krb5-config in PATH to detect the Heimdal version and bail
with a misleading message otherwise. :(
That's perfectly OK. 

You obviously disagreed with yourself later on ;) and replaced the comment
I introduced in acinclude.m4 with a suitable fix (which made it into 0.10.4):

http://www.ethereal.com/cgi-bin/viewcvs.cgi/ethereal/acinclude.m4.diff?r1=1.73&r2=1.74

Thanks for that. I needed another small patch (attached) to make
"--with-krb5=/path/to/dir" work for me even without krb5-config in PATH, though.

Please review and apply.

As for further improvements: in case of "--with-krb5=/path/to/dir" we should
look for krb5-config in /path/to/dir/bin (in addition to PATH) and use it.


+Thomas

--
Thomas Anders (thomas.anders at blue-cable.de)

--- acinclude.m4.FCS	2004-05-14 00:38:02.000000000 +0200
+++ acinclude.m4	2004-05-14 11:38:46.000000000 +0200
@@ -880,6 +880,7 @@
 	  CPPFLAGS="$CPPFLAGS -I$krb5_dir/include"
 	  #ethereal_save_LIBS="$LIBS"
 	  #LIBS="$LIBS -lkrb5 -lasn1 -lcrypto -lroken -lcrypt -lresolv"
+	  KRB5_LIBS="-lkrb5 -lasn1 -lcrypto -lroken -lcrypt -lresolv"
 	  ethereal_save_LDFLAGS="$LDFLAGS"
 	  LDFLAGS="$LDFLAGS -L$krb5_dir/lib"
 	  ac_krb5_version=`grep -i heimdal $krb5_dir/include/krb5.h | head -n 1 | sed 's/^.*heimdal.*$/HEIMDAL/i'`