Wireshark · Ethereal-dev: Re: [Ethereal-dev] IrDA dissector plugin

[Jean Tourrilhes <jt@xxxxxxxxxxxxxxxxxx>]

On Thu, Dec 18, 2003 at 01:21:12PM -0800, Guy Harris wrote:
> 
> On Dec 18, 2003, at 11:07 AM, Guy Harris wrote:
> 
> >Checked in, with changes to add the IrDA plugin to the NSIS package and
> >to add WTAP_ENCAP_IRDA to the table in wiretap/wtap.c.

	Thanks, that's great ! I'm glad all the work we did together
is finally usable.
	Personally, I'm pretty proud of the approach we have taken (as
opposed to, let say, BlueTooth capture), as it minimise the amount of
code specific to IrDA and offer maximum flexibility.

> I removed the check for IrDA interfaces from "capture.c" - I just 
> checked a change into the main and 0.8 branches of libpcap that should 
> support a minimum level of filtering in DLT_LINUX_IRDA interfaces  (an 
> empty filter expression should work, i.e. should generate a program 
> that accepts all packets, and filter expressions testing "link[M:N]" 
> should also work, but no other expressions will, e.g. "link proto ip" 
> won't work).  That should appear in 0.8 when it's released.

	I'm at fault here, when I first read the filter code I was not
sure how to specify "no filter". Yes, my stuff was a hack and I
believe your approach is better, we will need to test that ;-)

	Thanks...

	Jean