Ethereal-dev: Re: [Ethereal-dev] SPX Dissection problem.

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Wed, 9 Apr 2003 15:36:48 -0700
On Wed, Apr 09, 2003 at 02:15:59PM -0700, Guy Harris wrote:
> On Wed, Apr 09, 2003 at 02:57:34PM -0600, Greg Morris wrote:
> > I guess if I would have
> > just not processed the packet then I would not have had to worry about
> > it in the NDPS code.
> 
> Yup.

I've checked in a change to make the SPX dissector not supply
retransmitted packets to subdissectors; instead, it puts an FT_FRAMENUM
item into the protocol tree, with the original frame number as a value
(so you can use the "Go to Corresponding Frame" menu item to go to that
frame), corresponding to the SPX payload.

I've changed the NDPS dissector not to check for retransmissions.

The SPX dissector still passes extra data to the subdissector; it passes
a structure containing:

	the value of the end-of-message bit;

	the value of the datastream type;

under the assumption that both of those are data intended for the
protocol running atop SPX (except when the datastream type is "end of
connection" or "end of connection ack").