Ethereal-dev: Re: [Ethereal-dev] Updates for NCP, NDS, SPX, and NDPS

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <guy@xxxxxxxxxx>
Date: Mon, 7 Apr 2003 19:01:31 -0700
On Mon, Apr 07, 2003 at 06:02:01PM -0700, Guy Harris wrote:
> as well as the "might be used uninitialized" warning, which is a *real*
> warning - if "pinfo->fd->flags.visited" is true, "spx_data" contains
> random junk.

I've checked in a change that arranges that the hash structure for the
packet is passed to the subdissector regardless of whether
"pinfo->fd->flags.visited" is true or not - and gets rid of the
"retransmission" field, as there's only one hash structure for both the
initial transmission and all retransmissions of the packet, and not all
of them can have the same value for "retransmission"; instead, whether
it's a retransmission or not is checked by comparing the "num" field of
the structure with the current frame number.

The conversation that the SPX dissector creates uses "pinfo->srcport" as
both the source and destination port numbers; should it use
"pinfo->srcport" and "pinfo->destport"?