On Mon, Apr 07, 2003 at 05:00:39PM -0600, Greg Morris wrote:
> The attached DIFFS add the following...
>
> ncp2222.py - Op-lock level 2 support, added additional error codes
Checked in.
> packet-ipx.c & packet-ipx.h- Added SPX retransmission code
Checked in.
Should the protocol tree have a Boolean "this is a retransmission" item,
so you can filter or search for retransmissions?
Should the SPX dissector refuse to call the subdissector if the packet
is a retransmission, so that the NDPS dissector (and other dissectors it
calls) don't have to worry about retransmissions?
> packet-ncp2222.inc - Fixed Server Busy type 0x9999 packets
Checked in.
> packet-ncp.c - Added fix for reply packets containing packet
> signatures
I'm not sure that'd work. It uses a global variable to remember whether
the request was signed; however, there's no guarantee, except on the
first pass through the packets, that the packet dissected just before
a reply packet is dissected is a request packet, so you'd have to attach
the "is signed" flag to the reply as per-packet data. As long as you're
doing that, you might also want to have the "is signed" flag be
per-conversation data rather than a global variable.
> packet-ncp-int.h - fixed comments
Checked in.
> packet-ndps.h & packet-ndps.c - Complete decodes for NetWare NDPS
> packets
See previous comment about retransmissions.
There are a number of "unused variable" and "comparison between signed
and unsigned" warnings:
packet-ndps.c: In function `name_or_id':
packet-ndps.c:1612: warning: unused variable `length'
packet-ndps.c: In function `objectidentification':
packet-ndps.c:1637: warning: unused variable `length'
packet-ndps.c:1634: warning: unused variable `object_count'
packet-ndps.c:1633: warning: unused variable `h'
packet-ndps.c: In function `attribute_value':
packet-ndps.c:1842: warning: unused variable `citem'
packet-ndps.c:1841: warning: unused variable `ctree'
packet-ndps.c:1840: warning: unused variable `bitem'
packet-ndps.c:1839: warning: unused variable `btree'
packet-ndps.c:1818: warning: unused variable `number_of_values'
packet-ndps.c:1815: warning: unused variable `h'
packet-ndps.c: In function `ndps_req_hash_cleanup':
packet-ndps.c:3082: warning: unused variable `request_value'
packet-ndps.c: In function `dissect_ndps':
packet-ndps.c:3179: warning: unused variable `frame_num'
packet-ndps.c: In function `ndps_defrag':
packet-ndps.c:3320: warning: unused variable `id'
packet-ndps.c:3324: warning: `spx_data' might be used uninitialized in this function
packet-ndps.c: In function `dissect_ndps_request':
packet-ndps.c:3708: warning: comparison between signed and unsigned
packet-ndps.c:5871: warning: comparison between signed and unsigned
packet-ndps.c:3490: warning: unused parameter `ndps_xid'
packet-ndps.c: In function `ndps_error':
packet-ndps.c:6434: warning: comparison between signed and unsigned
packet-ndps.c: In function `dissect_ndps_reply':
packet-ndps.c:6655: warning: comparison between signed and unsigned
packet-ndps.c:7959: warning: comparison between signed and unsigned
packet-ndps.c:6501: warning: unused variable `field_len'
packet-ndps.c:6499: warning: unused variable `problem_type'
packet-ndps.c: At top level:
packet-ndps.c:2956: warning: `filteritem' defined but not used
packet-ndps.c:3019: warning: `ddp_dissector_table' defined but not used
as well as the "might be used uninitialized" warning, which is a *real*
warning - if "pinfo->fd->flags.visited" is true, "spx_data" contains
random junk.
