Ethereal-dev: Re: [Ethereal-dev] [patch] spoolss updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Tim Potter <tpot@xxxxxxxxx>
Date: Sun, 17 Feb 2002 10:20:23 -0800
On Sat, Feb 16, 2002 at 05:33:00PM -0800, Guy Harris wrote:

> > I've split out some of the useful request/response and policy handle
> > tracking code into a separate file for sharing between the LSA, SAMR,
> > SPOOLSS and WINREG dissectors.  I would also like to rename the
> > packet-dcerpc-nt.{c,h} files to packet-dcerpc-smb.{c,h} as it's a more
> > appropriate name.
> 
> If you do that, you'll have to update "packet-dcerpc-lsa.c" (that
> doesn't seem to have been updated in the patch) and "Makefile.nmake"
> (adding new source files, removing source files, or renaming source
> files requires that to change as well).

D'oh!  Is there any way to have Makefile.am and Makefile.nmake be
derived from a common source?  I do zero win32 development so I always
forget to update the win32 Makefile.

> In one capture I've seen, a GetPrinter response was dissected by the old
> code showing all the information in the "Data" portion of the
> "BUFFER_DATA" part of the reply as a "PRINTER_INFO_0"; the new code just
> shows it as undissected data.

Oops.  Sigh - I'm on the road at the moment and don't have access to my
test scripts.  I'll look at cleaning this up some more.


Thanks,

Tim.