Ethereal-dev: Re: [Ethereal-dev] [patch] spoolss updates

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

From: Guy Harris <gharris@xxxxxxxxx>
Date: Sat, 16 Feb 2002 17:33:00 -0800
On Fri, Feb 15, 2002 at 10:26:27AM -0800, Tim Potter wrote:
> Since Ronnie is working so fast I though I would submit some updates to
> the DCERPC over SMB spoolss decoder.  I'd already started on some
> NETLOGON things (basically the three functions that Samba uses) but I
> guess I'll have to trash them.
> 
> I've split out some of the useful request/response and policy handle
> tracking code into a separate file for sharing between the LSA, SAMR,
> SPOOLSS and WINREG dissectors.  I would also like to rename the
> packet-dcerpc-nt.{c,h} files to packet-dcerpc-smb.{c,h} as it's a more
> appropriate name.

If you do that, you'll have to update "packet-dcerpc-lsa.c" (that
doesn't seem to have been updated in the patch) and "Makefile.nmake"
(adding new source files, removing source files, or renaming source
files requires that to change as well).

In one capture I've seen, a GetPrinter response was dissected by the old
code showing all the information in the "Data" portion of the
"BUFFER_DATA" part of the reply as a "PRINTER_INFO_0"; the new code just
shows it as undissected data.