Hi list
Attached patch is applied ontop of previous patch.
This is a work in progress.
The patch cleans up smb_info_t quite a lot and reduces the number
of variebles lying around.
I think this patch also makes the conversation/hashing much easier to
follow and understand.
With this patch ethereal should have no problem with any client
reusing MIDs.
I tested on a ~100.000 capture which consisted of a smaller capture
concatenated some 50 times to produce a larger one. This produced a large
capture where each command was repeated 50 times.
Ethereal could follow response_to/request_in fine.
I also tested with a small patch with two different commands but with both
commands using the same MID. It also worked fine.
There is a memory leak in packet-smb-pipe.c which is introduced with this
patch.
I also suspect there might be a bug causing a crash somewhere in
packet-smb-pipe but I have not tracked it down or verified it yet.
When testing with a 100.000 packet capture filled with SMB commands
the RSS of ethereal was reduced by 3Mb to 50Mb with this patch so there are
memory savings.
please comment.
_________________________________________________________________
Get your FREE download of MSN Explorer at http://explorer.msn.com/intl.asp
Attachment:
smb_patch2.diff.gz
Description: Binary data
