Wireshark · Ethereal-dev: Re: [Ethereal-dev] patch for MTP3 (+= ANSI support)

[Jeff Morriss <jeff.morriss@xxxxxxxxxxx>]

Guy Harris wrote:
> 
> > The only "damage" to the ITU part is that the "mtp3.sls" field is no
> > longer bitmasked in the header fields section (since the SLS in ANSI can
> > be 5 or 8 bits and in ITU it's only 4).
> 
> Perhaps there should be separate "mtp3.sls_itu", "mtp.sls_ansi_5bits",,
> and "mtp3.sls_ansi_8bits" fields?

I had contemplated that, but...  I guess I don't like the concept of
having "too many" fields, especially when they are basically the same
thing but just different sizes (because we're supporting multiple
standards).  As it is now the only thing we really lose by doing it this
way is the pretty bitmask output in the GUI (I think).

My other thinking was that as a user I'd like to be able to just add a
filter like "mtp3.sls == 1" and not have to worry about such a long name
for the field.

But, obviously I'm fairly new to Ethereal development, so I don't know
what the convention is in this type of situation.  To me this is an
interesting question because this is bound to come up again if we
continue to add SS7 protocols.

Regards,
-Jeff

begin:vcard 
n:Morriss;Jeff
tel;fax:+1-856-222-9947
tel;work:+1-856-787-2824
x-mozilla-html:FALSE
url:http://www.ulticom.com
org:Ulticom, Inc.;Customer Support
version:2.1
email;internet:jeff.morriss@xxxxxxxxxxx
title:Product Support Engineer
adr;quoted-printable:;;Ulticom, Inc.=0D=0A1020 Briggs Rd.=0D=0A;Mount Laurel;NJ;08054;USA
fn:Jeff Morriss
end:vcard