On Thu, Mar 08, 2001 at 01:45:35AM -0800, Guy Harris wrote:
> Some additional comments:
>
> Instead of printing "packet selected is not a TCP segment" if the user
> selects something from the "TCP Stream Analysis" menu if the packet
> selected isn't a TCP segment, you should probably just make the "TCP
> Stream Analysis" menu item insensitive if the selected packet isn't a
> TCP segment - or, rather, if it's not a packet the code can handle.
>
> See, for example, "set_menus_for_selected_packet()", which, if a packet
> has been selected, makes the "/Tools/Follow TCP Stream" item sensitive
> or insensitive depending on whether the currently selected packet is a
> TCP packet.
This is on the TODO list. The message was meant mainly as a reminder to
myself. I'll fix it.
> The "control" dialog box for the graph, and the graph window itself,
> should probably be given titles to indicate what they are.
I'll fix this.
> The "control" dialog box seems to suffer a bit from Boeing 747 Cockpit
> Disease (which may be an unfair name, these days, but, once upon a time,
> I heard people speak of Very Complicated Sets Of Controls as being like
> a 747's cockpit) - it has a lot of buttons and knobs and dials. A
> scheme like that used by some Windows dialog boxes, with an "Advanced
> >>>" button that, when clicked, makes visible a pile of widgets with the
> less-commonly-used controls, might help here. (The Zoom and Magnify
> controls might be ones put under "Advanced" - there's a lot of numbers
> to tweak there, and I suspect most people would prefer to tweak them
> graphically rather than by typing in numbers or even clicking on the
> spin buttons.)
I've tried a couple of variants here (I especially liked the idea to
divide the controls using a notebook widget) but unfortunately I was
unable to decide which knobs should go where so I ended up with what you
see - I crammed everything into one window in hope that actual usage
will reveal what belongs to an "advanced" section. This is a sensitive
topic - I can tell you that I'm playing with Magnify controls all the
time (the right geometry and zoom of the Magnify window depends heavily
on geometry and zoom of main window) so personally I would end up with
the "advanced" window always open. Would you object to the notebook
idea?
pvl
