Hi,
I'm using your tool to analyse ISDN D-channel trace files generated by
our Fax-Boards. It seems there are some typos in packet-q931.c which
result in misinterpretation of Q.931 message types and Q.931 call
states. The corrected version of the Q.931 frame disassembler works
fine for me. A diff-file containing my changes is attached to this
mail.
Best regards
Thomas Gimpel
--
+----------------+--------------------------------------------------+
| ____ | Thomas Gimpel |
| /___/ | Electronic Design Engineer |
| / _/ | Ferrari electronic AG |
| /_/e/r/r/a/r/i | phone : +49 3328 4559 0 fax: +49 3328 4559 60 |
| electronic | E-Mail: Thomas.Gimpel@xxxxxxxxxx |
+----------------+--------------------------------------------------+
diff -u --new-file --recursive ethereal-0.8.16.orig/packet-q931.c ethereal-0.8.16/packet-q931.c
--- ethereal-0.8.16.orig/packet-q931.c Mon Feb 12 00:19:00 2001
+++ ethereal-0.8.16/packet-q931.c Thu Mar 8 10:54:36 2001
@@ -78,7 +78,7 @@
#define Q931_CONNECT_ACK 0x0F
#define Q931_PROGRESS 0x03
#define Q931_SETUP 0x05
-#define Q931_SETUP_ACK 0x0B
+#define Q931_SETUP_ACK 0x0D
#define Q931_HOLD 0x24
#define Q931_HOLD_ACK 0x28
#define Q931_HOLD_REJECT 0x30
@@ -1095,14 +1095,15 @@
{ 0x04, "Call delivered" },
{ 0x06, "Call present" },
{ 0x07, "Call received" },
- { 0x09, "Connect request" },
- { 0x0A, "Incoming call proceeding" },
- { 0x0B, "Active" },
- { 0x0C, "Disconnect request" },
- { 0x0F, "Disconnect indication" },
- { 0x11, "Suspend request" },
- { 0x13, "Resume request" },
- { 0x16, "Release request" },
+ { 0x08, "Connect request" },
+ { 0x09, "Incoming call proceeding" },
+ { 0x0A, "Active" },
+ { 0x0B, "Disconnect request" },
+ { 0x0C, "Disconnect indication" },
+ { 0x0F, "Suspend request" },
+ { 0x12, "Resume request" },
+ { 0x13, "Release request" },
+ { 0x16, "Call Abort"},
{ 0x19, "Overlap receiving" },
{ 0x3D, "Restart request" },
{ 0x3E, "Restart" },
