Ethereal-dev: RE: [Ethereal-dev] [grin@xxxxxxxxxxxxxxx: Bug#81164: ethereal: se gfault analys

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Jeff Foster <jfoste@xxxxxxxxxxxx>
Date: Wed, 10 Jan 2001 08:43:22 -0600
From: Guy Harris [mailto:gharris@xxxxxxxxxxxx]
Sent: Wednesday, January 10, 2001 5:00 AM

> On Tue, Jan 09, 2001 at 02:27:28PM -0600, Jeff Foster wrote:
> Attached is a patch file to fix this problem in the socks dissector.
> 
> Checked in.  (It appears to set the dissector for the SOCKS
> conversation; does that prevent the ping-ponging?)
> 

This won't fix the ping-ponging problem (at least for this case)
because the problem is  really in the smtp dissector. It would
have to set the conversation dissector to correct the problem.

We should 

1) Document that a conversation dissector should be set when a
new conversation is created and hope that developers do that.

or

2) Modify the conversation_new call to require a dissector.  


I lean toward suggestion 2 because it is more reliable.


Jeff Foster
jfoste@xxxxxxxxxxxx