Ethereal-dev: Re: [Ethereal-dev] Patch to packet-lapb.c to do LAPBETHER as well

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Richard Sharpe <sharpe@xxxxxxxxxx>
Date: Wed, 27 Dec 2000 23:34:06 +1000
At 04:53 AM 12/27/00 -0800, Guy Harris wrote:
>On Wed, Dec 27, 2000 at 11:16:11PM +1000, Richard Sharpe wrote:
>> Here is a proposed patch to packet-lapb.c that allows both LAPB and
>> LAPBETHER frames to be dissected.
>> 
>> It distinguishes between LAPB and LAPBETHER by looking at pi.match_port
>> checking for ETHERTYPE_DEC ...
>
>The LAPB dissector is a tvbuffified dissector, so if it does that, it
>should look at "pinfo->match_port", not "pi.match_port".

Errr, yes, you are right ...

>> While it complicates the lapb dissector, I felt that it did not warrant an
>> separate dissector ...
>
>I'd still prefer that there be a separate LAPB-over-Ethernet dissector,
>which extracts the length field and then calls an unmodified LAPB
>dissector, along the lines of, for example, the X.25-over-TCP dissector.

Grumble, mumble, OK ... I guess it is only half an hour's work with emacs
... next few days ...


Regards
-------
Richard Sharpe, sharpe@xxxxxxxxxx
Samba (Team member, www.samba.org), Ethereal (Team member, www.zing.org)
Contributing author, SAMS Teach Yourself Samba in 24 Hours
Author, Special Edition, Using Samba