Ethereal-dev: Re: [Ethereal-dev] Patch to packet-lapb.c to do LAPBETHER as well

Note: This archive is from the project's previous web site, ethereal.com. This list is no longer active.

Date Index Thread Index Other Months All Mailing Lists
Date Prev Date Next Thread Prev Thread Next
From: Guy Harris <gharris@xxxxxxxxxxxx>
Date: Wed, 27 Dec 2000 04:53:17 -0800
On Wed, Dec 27, 2000 at 11:16:11PM +1000, Richard Sharpe wrote:
> Here is a proposed patch to packet-lapb.c that allows both LAPB and
> LAPBETHER frames to be dissected.
> 
> It distinguishes between LAPB and LAPBETHER by looking at pi.match_port
> checking for ETHERTYPE_DEC ...

The LAPB dissector is a tvbuffified dissector, so if it does that, it
should look at "pinfo->match_port", not "pi.match_port".

> While it complicates the lapb dissector, I felt that it did not warrant an
> separate dissector ...

I'd still prefer that there be a separate LAPB-over-Ethernet dissector,
which extracts the length field and then calls an unmodified LAPB
dissector, along the lines of, for example, the X.25-over-TCP dissector.