Wireshark · Wireshark-dev: Re: [Wireshark-dev] Who introduced these failures?

[Pascal Quantin <pascal@xxxxxxxxxxxxx>]

Hi Richard,

Le mer. 21 avr. 2021 à 19:43, Richard Sharpe <realrichardsharpe@xxxxxxxxx> a écrit :

My latest MR failed with these errors:

-----------------------------
C:\builds\wireshark\wireshark\epan\dissectors\packet-componentstatus.c(172,71):
error C2220: workload = 100.0 *
CSR_GET_WORKLOAD(tvb_get_ntohs(message_tvb, 284));
[C:\builds\wireshark\wireshark\build\epan\dissectors\dissectors.vcxproj]
857C:\builds\wireshark\wireshark\epan\dissectors\packet-componentstatus.c(172,71):
error C2220: ^ [C:\builds\wireshark\wireshark\build\epan\dissectors\dissectors.vcxproj]
858 packet-cp2179.c
859C:\builds\wireshark\wireshark\epan\dissectors\packet-componentstatus.c(172,71):
warning C4244: '=': conversion from 'double' to 'float', possible loss
of data [C:\builds\wireshark\wireshark\build\epan\dissectors\dissectors.vcxproj]
-------------------------------

They are not in packet-ieee80211.c where my changes were.

This seems related to https://gitlab.com/wireshark/wireshark/-/merge_requests/2178 where no Windows build was run by the CI, and thus the error was left unnoticed prior to the merge. See the thread initiated by Anders earlier today.

Best regards,

Pascal.