Wireshark · Wireshark-dev: Re: [Wireshark-dev] File rename impacts Gitlab history

[chuck c <bubbasnmp@xxxxxxxxx>]

Thanks!

It's always an education poking around in the Gitlab gui file history/commits but this is much quicker.

admin1@MSEDGEWIN10:/mnt/c/Development/wireshark$ git log -p --follow epan/dissectors/packet-tls.c | grep -e "11129" -e "commit"
commit 17170ea1fe6fe8758897611a4375e57a4ee851cb
<snip>
commit cd95e197ca78feb1e83ec737b87ada0a1dd57d10
-    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.2", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
-    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.5", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
+    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.2", dissect_tls_sct_ber, proto_tls, "SignedCertificateTimestampList");
+    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.5", dissect_tls_sct_ber, proto_tls, "SignedCertificateTimestampList");
<snip>
commit e815bbb2e6946e210cd15b1d9c2d280332352c4e
     register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.2", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
     register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.5", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
<snip>
+    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.2", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
+    register_ber_oid_dissector("1.3.6.1.4.1.11129.2.4.5", dissect_tls_sct_ber, proto_ssl, "SignedCertificateTimestampList");
<snip>

On Fri, Feb 26, 2021 at 11:16 AM João Valverde via Wireshark-dev <wireshark-dev@xxxxxxxxxxxxx> wrote:

On 26/02/21 16:48, chuck c wrote:

https://gitlab.com/wireshark/wireshark/-/commit/50dbe4df7fd7a5e4e1a27fd5046981486d350994

Rename packet-ssl* to packet-tls*

Looking through history of 

https://gitlab.com/wireshark/wireshark/-/commits/master/epan/dissectors/packet-tls.c

https://gitlab.com/wireshark/wireshark/-/tree/2fd42045f5afb556a03d8a1090f3278c77798766

 "epan/dissectors/packet-tls.c" did not exist on "2fd42045f5afb556a03d8a1090f3278c77798766"

Is there any sort of work around (symbolic link?) that could be tracked in Git?

It now changes from "Browse File" to "Browse Directory" to look at earlier versions.

This is probably just a quirk of Gitlab's UI. It doesn't handle renames that smartly.

The answer to your question is to use "git log --follow" (which is what Gitlab is doing underneath).

thanks

chuckc

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe