Wireshark-dev: Re: [Wireshark-dev] Problem in 'packet-f5ethtrailer.c'
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <gharris@xxxxxxxxx>
Date: Thu, 19 Mar 2020 12:15:42 -0700
On Mar 19, 2020, at 11:38 AM, Guy Harris <gharris@xxxxxxxxx> wrote:

> In addition, we tend to use src_, rather than s_, as a prefix for "source", and "dst_" or "dest" as a prefix for "destination", so I posted a change to rename s_addr and d_addr to src_addr and dst_addr:
> 
> 	https://code.wireshark.org/review/36504
> 
> which should fix this.

Committed.

This does raise the question of why winsock2.h is getting dragged in; dissector have no need for that, any more than they have any need for UN*X networking API headers, unless they're making networking calls (in which case they should probably be using wsutil/socket.h to hide platform differences).