Wireshark-dev: Re: [Wireshark-dev] (34169) Pre-commit check failing incorrectly?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Mon, 5 Aug 2019 14:45:04 -0700
On Aug 5, 2019, at 2:37 PM, Dario Lombardo <lomato@xxxxxxxxx> wrote:

> On Mon, Aug 5, 2019 at 11:20 PM Guy Harris <guy@xxxxxxxxxxxx> wrote:
> 
>> On Aug 5, 2019, at 1:02 PM, Dario Lombardo <lomato@xxxxxxxxx> wrote:
>> 
>>> The message is telling you that ENC_BIG_ENDIAN has been used on a FT_UINT8 fiield,
>> 
>> If that's what it's telling you, it's lying - the line in question is adding hf_cdp_data, which is an FT_BYTES field.
> 
> Correct. I've checked on my source code and it's FT_BYTES indeed. Oliver, are you working on the current master?
> 
> However, despite the error message, the fail is correct: a FT_BYTES should not be given a ENC_BIG_ENDIAN, should it?

No, and it no longer is being used with ENC_BIG_ENDIAN, as of

	https://code.wireshark.org/review/c/34176/

(not that this was the result of anything Oliver did; it was an existing issue that just happened to be checked because of Oliver's change).