On 08/07/19 17:51, Pascal Quantin
wrote:
OK,
thanks.
But
then why is it reporting that an optional package
hasn’t been found if this package isn’t even
needed? It implies that there’s some feature
that’s not being built with Wireshark, does it
not?
As you can see in the about dialog on Windows you used
the builtin version instead of a shared library provided by
the system. That's all. João did this change to favor a
Speex version provided by the system over our copied version
(see https://code.wireshark.org/review/31857).
Adding to what Pascal said the external dependency on SpeexDSP was
added to benefit from upstream bug fixes and as a matter of best
practice. SpeexDSP could eventually be added to the Windows build
too.[1] There was a bit of discussion on how to present this
information to the user. It's optional only because there's a
bundled SpeexDSP snapshot (which I don't think has ever been synced
with upstream, although I could be wrong there).
[1]https://github.com/microsoft/vcpkg/tree/master/ports/speexdsp
When
compiling master
(v3.1.0rc0-1232-gd8ad7a686384) on
Windows, I noticed:
-- Could NOT find SpeexDSP
(missing: SPEEXDSP_LIBRARY
SPEEXDSP_INCLUDE_DIR)
-- The following OPTIONAL
packages have not been found:
—The
Speex codec has been obsoleted by
Opus.
It will continue to be available, but
since Opus is better than Speex in all
aspects, users are encouraged to
switch—
So
wouldn’t Opus be the way to go instead
of Speex?
The only part of Speex we
are using so far is the resampler and not
the codec if I'm not mistaken. On Windows we
use the internal Speex resampler and not the
system wide version. So nothing to worry
about :)
CONFIDENTIALITY NOTICE: This message is the property of
International Game Technology PLC and/or its subsidiaries
and may contain proprietary, confidential or trade secret
information. This message is intended solely for the use
of the addressee. If you are not the intended recipient
and have received this message in error, please delete
this message from your system. Any unauthorized reading,
distribution, copying, or other use of this message or its
attachments is strictly prohibited.
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
|
