On Dec 19, 2018, at 2:05 PM, Peter Wu <peter@xxxxxxxxxxxxx> wrote:
> IMO that commit should be reverted,
IMO this is unproven.
> it extends the public Lua API just
> to workaround an issue on Windows. We already override dofile/loadfile,
Which is *itself* a mistake, as far as I'm concerned. Why should all calls to dofile()/loadfile() look in the Wireshark configuration directories?
> so I'm investigating whether that can be patched in an appropriate way.
> (Aside from that there is also io.open, so the current fix is already
> incomplete.)
That's a *separate* problem; the bug in question is an issue with the "load Lua code" API, which, for better or worse, is a separate API from the "do file I/O" API.
There's more than one place where we're getting bitten by the different ways that non-ASCII pathnames are handled on UN*X and Windows; see, for example, bug 1827:
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1827
in which libsmi uses fopen() on a UTF-8 path.
