Wireshark · Wireshark-dev: Re: [Wireshark-dev] Looking for a base32_encode

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

Hi Antoine,

Le jeu. 29 nov. 2018 à 10:26, Antoine d'Otreppe <a.dotreppe@xxxxxxxxxx> a écrit :

Makes sense.

I had a look at a few sample implementations, the algorithm looks rather lengthy and error-prone. What's your policy on including source code from other open source projects? Which would be the best option?

1. pull code from another library (and then where do I put the copyright notice ?)

You can put the copyright notice at the beginning of the C file. But pelase ensure that the license is compatible with GPL2 or later (see https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses and https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility)

 

2. implement a new one in wireshark

Cheers,

Antoine

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

On Thursday, November 29, 2018 10:01 AM, Roland Knall <rknall@xxxxxxxxx> wrote:

If it's not in there, I would assume not. But you can allways submit a patch, which adds the functionality to wsutil/base32.c. We only implement function s that are actually needed.

kind regards

Roland

Am Do., 29. Nov. 2018 um 09:35 Uhr schrieb Antoine d'Otreppe <a.dotreppe@xxxxxxxxxx>:

Hi all,

Still working on the syncthing dissector, I need a base32_encode.

I've noticed there's a wsutil/base32.c file, which contains a base32_decode.

Unfortunately I couldn't find the corresponding encode.

Do we have that somewhere?

___________________________________________________________________________

Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>

Archives:    https://www.wireshark.org/lists/wireshark-dev

Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev

             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe