Wireshark · Wireshark-dev: Re: [Wireshark-dev] Is there a need for a 0, NULL element at the end of value strings

[Richard Sharpe <realrichardsharpe@xxxxxxxxx>]

On Tue, Oct 16, 2018 at 10:21 AM Guy Harris <guy@xxxxxxxxxxxx> wrote:
>
> On Oct 16, 2018, at 8:30 AM, Richard Sharpe <realrichardsharpe@xxxxxxxxx> wrote:
>
> > OK, ignore me. When you call g_array_new with TRUE in the first
> > argument you get a ZERO entry on the end.
>
> The fact that you had to ask this question - and probably had to look that up in the GLib documentation - suggests that there should be a comment before the g_array_new() call to indicate that the first argument being TRUE adds the necessary null terminator.  (*I* certainly didn't remember that the argument to g_array_new() indicates whether to put a zero terminator into the array; I suspect few people who aren't heavy GLib developers would know that without looking it up.)

Yes, that is what I did. It probably does require a comment. I will
add one before my next change set.

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者)