Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 7458f40: Diameter: add a bunch more AVPs from RFC 577

[Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>]

Hi folks,

Now that the Diameter XML is passing tools/validate-diameter-xml.sh again, could/should we add this verification check to the Petri dish and buildbot?  I had added it to pre-commit previously but it passes silently if the user does not have `xmllint` installed.

Regards,

-Jeff

On Fri, Sep 28, 2018 at 12:33 AM Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7458f40f1749699b3098a15ca1f8f0599f561dfa
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7458f40 by Jeff Morriss (jeff.morriss.ws@xxxxxxxxx):

    Diameter: add a bunch more AVPs from RFC 5777.

    Add enough AVPs to get the Diameter XML validating again.

    Also some whitespace and indentation cleanup.

    Change-Id: Ibebfc8832d50f6347e371ca4b8c5b81548e061a8
    Reviewed-on: https://code.wireshark.org/review/29898
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>


Actions performed:

    from  4761939   RPM: obsolete the gnome and gtk packages; allow user to set prefix.
     add  7458f40   Diameter: add a bunch more AVPs from RFC 5777.


Summary of changes:
 diameter/CiscoSystems.xml |   3 +-
 diameter/dictionary.xml   | 429 ++++++++++++++++++++++++++++++++++++----------
 2 files changed, 343 insertions(+), 89 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe