Wireshark · Wireshark-dev: [Wireshark-dev] not all libraries included in macOS DMG

[Peter Meiser <meiser@xxxxxxx>]

Hi,

I found another issue while building a DMG on macOS 10.13.3.

While collecting the libraries which need to be added to the app bundle, objdump shows an error as follows:

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/objdump: 'Wireshark.app/Contents/Frameworks/QtCore.framework': Is a directory


Therefore, I added a check to filter out all directories in the $lib_dep_search_list, so that only files are evaluated.

--- a/packaging/macosx/osx-app.sh
+++ b/packaging/macosx/osx-app.sh
@@ -368,8 +368,11 @@ while $endl; do
 	# when built by macosx-setup.sh.  We have to fix that; that's
 	# what the sed command does.
 	#
+	for i in $lib_dep_search_list; do
+		[ -f $i ] && libs="$libs $i";
+	done
 	libs="`\
-		otool -L $lib_dep_search_list 2>/dev/null \
+		otool -L $libs 2>/dev/null \
 		| fgrep compatibility \
 		| cut -d\( -f1 \
 		| sed '1,$s;^	libssh;	/usr/local/lib/libssh;' \


Regards,
Peter

PS: Please CC me as I'm not subscribed to the mailing list.