Wireshark · Wireshark-dev: Re: [Wireshark-dev] size_t under Windows ...

[Roland Knall <rknall@xxxxxxxxx>]

Not necessarily, in certain variations building WinXP and Win7 can lead to size_t being 4 byte, but the pointer PVOID either 8 byte or 4 byte depending on the target compile environment.

I would stick with a definition of size_t, because others will have to handle the right size, not us.

cheers

On Fri, Nov 24, 2017 at 11:56 AM, Dario Lombardo <dario.lombardo.ml@xxxxxxxxx> wrote:

Couldn't it be replaced by guint32 then, and the guard removed?

On Fri, Nov 24, 2017 at 10:45 AM, Helge Kruse <Helge.Kruse@xxxxxxx> wrote:

DWORD is a 32 bit unsigned integer.
size_t is platform dependent, 32 bits in 32 bit Windows and 64 bits in
64 bit Windows. I assume this is similar in other OS like Linux.
Therfore you can't replace DWORD by size_t without checking the impact.

Further there is an additional member cap_pipe_buf in the #ifdef(_WIN32) branch.

Regards
Helge
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe