Wireshark · Wireshark-dev: Re: [Wireshark-dev] Intro & first patch

[Ahmad Fatoum <ahmad@xxxxxx>]

Hello Brenton,

Welcome! For the packet capture, please open a Bugzilla ticket at https://bugs.wireshark.org,

preferably with the same title as your commit and attach your pcap files there.

Afterwards reference the Bugzilla ticket from the commit message of your patch on Gerrit by adding

Bug: 123456

Change-related discussions are best done on Gerrit. The cherry-picked commit has a link to the Gerrit discussion appended

and it's better to have everything at one place. The mailing list is geared more towards general discussions and questions.

Cheers,

Ahmad

On 9Oct 2017, at 21:41, Brenton Rothchild <brentonr@xxxxxxxx> wrote:

Hello everyone,

My name is Brenton Rothchild. I'm a freelance developer with an embedded C/C++ background.

I submitted my first patch, a change for Zigbee On/Off commands. I hope I followed all of the procedures correctly according to the Developer's Guide & Wiki. If not, please feel free to help me learn the correct way to submit changes and point out what I can do differently.

If there's any questions on the change, feel free to ping me via the list, or comments in Gerrit. 

I can also provide a sample capture file I've used for testing (I didn't see any way to post such an attachment to Gerrit directly?)

Looking forward to being able to contribute at least 1 small patch to such a great project!

Thanks!

-Brenton

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

Attachment: signature.asc
Description: Message signed with OpenPGP