Wireshark · Wireshark-dev: Re: [Wireshark-dev] Some updates to the Profinet plugin

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

The location seems okay to me. But did you push it to Gerrit? I can’t find it at https://code.wireshark.org/review/#/q/status:open

This is the best reference on this subject I have: https://wiki.wireshark.org/Development/SubmittingPatches

Regards,

Jaap

On 31 Aug 2017, at 08:45, Christoph Schmidt <chschmidt9@xxxxxxxxx> wrote:

Hi Dev-Team,

I made some changes to the Profinet plugin. I tried to follow the description how to apply changes to the Wireshark project but I'm a bit confused if I really did it in a correct way.

I committed my changes to refs/for/master/profinet-plugin-update. If I generate a revision graph with TortoiseGit it looks like this:

I hope that is the correct location.

The changes I did are mainly name changes so the names fit to the current Profinet specification. Also I extended one record. I hope that these changes will make it's way into the official Wireshark build.

Regards

Christoph Schmidt

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe