Wireshark · Wireshark-dev: Re: [Wireshark-dev] About wtap_pkthdr pack_flags

[Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>]

Hi Jaap,

Good idea to use #define value...

On Thu, May 18, 2017 at 9:38 PM, Jaap Keuter <jaap.keuter@xxxxxxxxx> wrote:

Hi list,

Why has wrap.h the following entry:

struct wtap_pkthdr {
...
    guint32   pack_flags;       /* XXX - 0 for now (any value for "we don't have it"?) */
...
};

while packet-frame.c defines numerous masks, e.g.:

#define PACKET_WORD_DIRECTION_MASK                        0x00000003
#define PACKET_WORD_RECEPTION_TYPE_MASK                   0x0000001C
#define PACKET_WORD_FCS_LENGTH_MASK                       0x000001E0
...

which is used to access this field later on:

                if (pinfo->phdr->presence_flags & WTAP_HAS_PACK_FLAGS) {
...


and pcapng.c uses hardcoded values, like so:

                if (wblock->packet_header->pack_flags & 0x000001E0) {
...


Shouldn’t:
1) the masks defined in packet-frame.c be moved to wrap.h
2) the wrap_pkthdr pack_flags field comment adjusted. and
3) pcapng.c make use of these masks.

Thanks,
Jaap

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@wireshark.org?subject=unsubscribe