Wireshark-dev: Re: [Wireshark-dev] main_toolbar.c in code tree but not in solution
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Graham Bloice <graham.bloice@xxxxxxxxxxxxx>
Date: Tue, 17 Jan 2017 18:00:20 +0000


On 17 January 2017 at 17:50, Paul Offord <Paul.Offord@xxxxxxxxxxxx> wrote:

Hi Graham,

 

I don’t seem to have that folder in my solution.  Here’s a screenshot:

 

 

I’ve changed main_toolbar.c by just navigating to the filesystem directory and then opening it.  I’m in git/git-review/Windows hell at the moment – I’ll take that up on a separate mail thread.  Once I get that working I’ll push the fix.


It's definitely built, look at the build output on the buildbot: https://buildbot.wireshark.org/wireshark-2.2/builders/Windows%20Server%202012%20R2%20x64/builds/420/steps/compile_1/logs/stdio and look for main_toolbar.c

I suspect you've somehow generated a solution without gtk being enabled.
 

 

Best regards…Paul

 

From: wireshark-dev-bounces@wireshark.org [mailto:wireshark-dev-bounces@wireshark.org] On Behalf Of Graham Bloice
Sent: 17 January 2017 17:31
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] main_toolbar.c in code tree but not in solution

 

 

 

On 17 January 2017 at 17:04, Paul Offord <Paul.Offord@xxxxxxxxxxxx> wrote:

Hi,

 

I’m working on a fix for Bug 12973.  It’s a very simple fix to main_window.cpp for the Qt UI and main_toolbar.c for the GTK one.  I’m working with source from a git clone taken this morning.  Although main_window.cpp is showing in the VS 2013 solution, main_toobar.c doesn’t.  Both files are in the code tree.

 

  • Is main_toolbar.c no longer needed?
  • Do I need to code a fix for the GTK UI?

 

Thanks and regards…Paul

 


main_toolbar.c is still used (see UI\gtkui\Source Files in the solution explorer) and yes, preferably fix both.

 

--

Graham Bloice



--
Graham Bloice