Wireshark · Wireshark-dev: Re: [Wireshark-dev] Wireshark building fails with code page errors on a non-English Windows system

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

Hi Yang,

2016-06-03 18:28 GMT+02:00 Pascal Quantin <pascal.quantin@xxxxxxxxx>:

Le 3 juin 2016 18:24, "Yang Luo" <hsluoyb@xxxxxxxxx> a écrit :
>
> Hi Pascal,
>
> On Fri, Jun 3, 2016 at 11:12 PM, Pascal Quantin <pascal.quantin@xxxxxxxxx> wrote:
>>
>> Hi Yang
>>
>> 2016-06-03 17:03 GMT+02:00 Yang Luo <hsluoyb@xxxxxxxxx>:
>>>
>>> Hi list,
>>>
>>> I made a post on this list several months ago about compile errors of Wireshark on Windows:. http://seclists.org/wireshark/2015/Dec/125
>>>
>>> The errors are something like:
>>>
>>> 91>J:\github_repos\wireshark-win64-libs\gtk2\include\glib-2.0\gobject/gsignal.h: warning C4819: The file contains a character that cannot be represented in the current code page(936). Save the file in Unicode format to prevent data loss (J:\github_repos\wireshark\ui\gtk\about_dlg.c)
>>> [J:\github_repos\wsbuild64\ui\gtk\gtkui.vcxproj]
>>>
>>> 91>J:\github_repos\wireshark-win64-libs\gtk2\include\glib-2.0\gobject/gsignal.h: warning C4819: The file contains a character that cannot be represented in the current code page(936). Save the file in Unicode format to prevent data loss (J:\github_repos\wireshark\ui\gtk\addr_resolution_dlg.c)
>>> [J:\github_repos\wsbuild64\ui\gtk\gtkui.vcxproj]
>>>
>>>
>>> I didn't actually solve this issue at that time. These days I revisited this issue. And I tried Graham's method of using PowerShell (http://seclists.org/wireshark/2015/Dec/127) but with no luck.
>>>
>>> I also tried to switch my CMD session to Unicode by running "chcp 65001" based on this post: http://stackoverflow.com/questions/14109024/how-to-make-unicode-charset-in-cmd-exe-by-default, but also the same errors.
>>>
>>> Finally I found a workaround. I went to "Control Panel" -> "Region" window -> "Administrative" tab -> Change system locale.." button, then switched the locale from Chinese to English, then rebooted. And the compile went through smoothly this time.
>>> But in English locale, all my ANSI programs including .txt files with Chinese characters are broken. They all show messy code. So this is only a temporary hack.
>>>
>>> I wonder how other non-English Windows users compile Wireshark? Is there a better solution to solve this issue? I'm using Win10 x64 system.
>>
>>
>> If you edit the github_repos\wireshark-win64-libs\gtk2\include\glib-2.0\gobject\gsignal.h file line 916 and replace the elipsis sign by ..., can you build with your Chinese locale?
>
>
> I think you maybe want to say line 516 as Gerald said, and it works! I can build Wireshark with Chinese locale now!

Thanks for confirming and sorry for the typo.
I will repackage the gtk2 bundle with this change and update our build system.

The change can be found here: https://code.wireshark.org/review/#/c/15713/

Regards,

Pascal