Wireshark · Wireshark-dev: [Wireshark-dev] Commit 3c1f71e: Build error "unused parameter 'ntlm_pass' [-Werror=unused-parameter]

[Uli Heilmeier <zeugs@xxxxxxxxxxxx>]

Hi list,

since commit 3c1f71e my build system has failed in compiling the current master.

The error is:

----
  CC       packet-dcerpc-rep_proc.lo
packet-dcerpc-netlogon.c: In function 'get_keytab_as_list':
packet-dcerpc-netlogon.c:6561:71: error: unused parameter 'ntlm_pass' [-Werror=unused-parameter]
 static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass)
                                                                       ^
---

When I revert one change compilation works again.

--- a/epan/dissectors/packet-dcerpc-netlogon.c
+++ b/epan/dissectors/packet-dcerpc-netlogon.c
@@ -6558,7 +6558,7 @@ static void str_to_unicode(const char *nt_password, char *nt_password_unicode)
 }
 #endif

-static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass)
+static guint32 get_keytab_as_list(md4_pass **p_pass_list, const char* ntlm_pass _U_ )
 {
 #ifdef HAVE_KERBEROS
     enc_key_t *ek;

I've already did a 'git clean -d -X -i; ./autogen.sh; ./configure --with-kerberos --with-ssl --with-geoip' to have a
clean repository.

Any idea what's going wrong here?

Thanks for any help!
Uli