Wireshark · Wireshark-dev: Re: [Wireshark-dev] QT translation: lock keyboard shortcut terms?

[Uli Heilmeier <zeugs@xxxxxxxxxxxx>]

Hi Alexis,

>     How can we prevent this?
>     * Remove keyboard shortcuts from the wireshark_xx.ts file (if feasible)
> 
> After a check, yes, it is possible to remove (via Qt Design for example
> "Close"
> diff --git a/ui/qt/main_window.ui b/ui/qt/main_window.ui
> index 021d788..881f6c7 100644
> --- a/ui/qt/main_window.ui
> +++ b/ui/qt/main_window.ui
> @@ -817,7 +817,7 @@
>      <string>Close this capture file</string>
>     </property>
>     <property name="shortcut">
> -    <string>Ctrl+W</string>
> +    <string notr="true">Ctrl+W</string>
>     </property>
>     <property name="iconVisibleInMenu">
>      <bool>false</bool>
> 
> and after it is remove from ts file
> 

Sounds good. I would vote for removing the terms from the ts files.

If no one complains I will upload a patch with fixed ui file in the next days.

>     * Establish a review process (like Gerrit) for translation files
>
> It is possible to have "Reviewer" on Transifex, if you are interresed and
> can add you to reviewer group for check german translation
>

Keeping the automatic sync (without review) is ok for me when we've
removed the shortcuts from ts file.

Cheers
Uli