Wireshark · Wireshark-dev: Re: [Wireshark-dev] Deprecating nmake

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

2016-04-03 16:35 GMT+02:00 RobiOneKenobi <robionekenobi@xxxxxxxxxx>:

Hi,

 

I have also the 64bit version of Python 2.7 (and now also the 64bit version of Cmake - cmake-3.5.20160325-g021e0-win64-x64)

 

Yes right, on win64 and win32 now the Configure ends at the same place

 

CMake Error at CMakeLists.txt:1225 (FEATURE_SUMMARY):
Unknown CMake command "FEATURE_SUMMARY".
-- Configuring incomplete, errors occurred!

This is weird: FEATURE_SUMMARY is a command bundled in CMake: https://cmake.org/cmake/help/v3.5/module/FeatureSummary.html

I guess editing CMakeList.txt and replacing FEATURE_SUMMARY by feature_summary does not make a difference?

Robert

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Pascal Quantin
Sent: Sunday, April 3, 2016 4:16 PM

To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Deprecating nmake

 

Le 3 avr. 2016 4:13 PM, "RobiOneKenobi" <robionekenobi@xxxxxxxxxx> a écrit :
>
> Hi,
>
>  
>
> I had CMake 3.5.1 x86 installed, so I de-installed it and installed Cmake 3.5.1 x64.

I have CMake x86. In my previous email I was making reference to the Python version, not the CMake one.
But in your previous email you said that the error was no more present?

>
>  
>
> The error is always the same L
>
>  
>
> Win64
>
> Didn’t find python module
>
>  
>
> Win32  
>
> Didn’t find FEATURE_SUMMARY
>
>  
>
> Robert
>
>  
>
>  
>
> From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Pascal Quantin
> Sent: Sunday, April 3, 2016 1:08 PM
>
> To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
> Subject: Re: [Wireshark-dev] Deprecating nmake
>
>  
>
>  
>
>  
>
> 2016-04-03 11:21 GMT+02:00 RobiOneKenobi <robionekenobi@xxxxxxxxxx>:
>>
>> Hi,
>>
>> Checked path and only the python 2.7 (c:\pythoin27) is used. What is
>> surprising, is that the Win32 Config works for python, but not the Win64
>> Config.
>
>  
>
> Have you installed the 32 bits of 64 bits variant of Python? On muy side I installed the 64bits version and CMake 3.5.1 has no issue locating it when building Wireshark for x86 or x64.
>>
>>
>> The second error (when Win32 Config) mean that the FEATURE_SUMMARY is at no
>> place (I made a search in all files in the WS Source Dir, and it is found in
>> only one place (where it is called and bringing the error))
>>
>> Robert
>>
>> -----Original Message-----
>> From: wireshark-dev-bounces@xxxxxxxxxxxxx
>> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Roland Knall
>> Sent: Saturday, April 2, 2016 6:00 PM
>> To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
>>
>> Subject: Re: [Wireshark-dev] Deprecating nmake
>>
>> Try to set the path to the Python Executable in cmake. Seems he catches the
>> Cygwin version by mistake.
>>
>> Regards
>>
>> > Am 02.04.2016 um 16:07 schrieb RobiOneKenobi <robionekenobi@xxxxxxxxxx>:
>> >
>> > Hi,
>> >
>> > I'm trying to migrate to CMake, but i'm facing 2 problems
>> >
>> > In Win64, it stops after a few lines with:
>> >
>> > CMake Error at cmake/modules/LocatePythonModule.cmake:45 (message):
>> >  Could NOT find python module asn2wrs
>> > Call Stack (most recent call first):
>> >  cmake/modules/UseAsn2Wrs.cmake:9 (locate_python_module)
>> >  CMakeLists.txt:205 (include)
>> > -- Configuring incomplete, errors occurred!
>> >
>> >
>> > In Win32, it goes further (as it find the python module) but stops later:
>> >
>> > CMake Error at CMakeLists.txt:1225 (FEATURE_SUMMARY):
>> >  Unknown CMake command "FEATURE_SUMMARY".
>> > -- Configuring incomplete, errors occurred!
>> >
>> > Thanks for your help
>> > Robert
>> >
>> > -----Original Message-----
>> > From: wireshark-dev-bounces@xxxxxxxxxxxxx
>> > [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Gerald Combs
>> > Sent: Wednesday, March 23, 2016 6:54 PM
>> > To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
>> > Subject: [Wireshark-dev] Deprecating nmake
>> >
>> > Wireshark currently uses four build systems: GNU Autotools, CMake, and
>> nmake
>> > (which in turn depends on QMake). In order to preserve sanity and reduce
>> > development friction it would be nice if we could remove the last two.
>> >
>> > Toward that end I have a pending change at
>> > https://code.wireshark.org/review/#/c/14591/ which generates an error if
>> you
>> > try to build using nmake. You can disable the error by setting
>> > YES_I_KNOW_ABOUT_THE_DEPRECATION, either on the command line or in
>> > config.nmake. I plan on submitting it on Friday. I also plan on removing
>> the
>> > remaining nmake steps from the master and master-2.0 buildbots some time
>> > today.
>> >
>> > The next step will be the removal of the various Makefile.nmakes and
>> related
>> > files from Git. This is tentatively planned for some time in June, either
>> > immediately before or after Sharkfest in order to give people plenty of
>> time
>> > to migrate to CMake. Note that the master-2.2 branch will likely not
>> include
>> > nmake support from its inception.
>> >
>> > If you're still using nmake you should definitely plan on migrating to
>> CMake
>> > by June. The Developer's Guide has been updated to include instructions
>> for
>> > CMake:
>> >
>> > https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>> >
>> > If you run into any issues don't hesitate to send a message to
>> wireshark-dev
>> > or post a question on ask.wireshark.org. Many of us will also be at
>> > Sharkfest and should be able to help in person.
>> >
>> ___________________________________________________________________________
>> > Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> > Archives:    https://www.wireshark.org/lists/wireshark-dev
>> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>> >             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>> > <CMakeWS_Win32_Out.txt>
>> > <CMakeWS_Win64_Out.txt>
>> >
>> ___________________________________________________________________________
>> > Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> > Archives:    https://www.wireshark.org/lists/wireshark-dev
>> > Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>> >             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>>
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
>
>  
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe