Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master e282c19: autotools: Fix multiple
From: João Valverde <joao.valverde@xxxxxxxxxxxxxxxxxx>
Date: Mon, 22 Feb 2016 14:48:51 +0000


On 22-02-2016 14:28, Jeff Morriss wrote:

On Sun, Feb 21, 2016 at 2:45 AM, Wireshark code review
<code-review-do-not-reply@xxxxxxxxxxxxx
<mailto:code-review-do-not-reply@xxxxxxxxxxxxx>> wrote:

    e282c19 by João Valverde (joao.valverde@xxxxxxxxxxxxxxxxxx
    <mailto:joao.valverde@xxxxxxxxxxxxxxxxxx>):

         autotools: Fix multiple repetitions of -L build flags

         Before:

           WS_LDFLAGS=' -Wl,--as-needed -L/usr/local/lib
    -L/usr/local/lib -L/usr/local/lib -L/usr/local/lib -L/usr/local/lib'

         After:

           WS_LDFLAGS=' -Wl,--as-needed -L/usr/local/lib'

         Bumps autoconf required version to 2.64.


FWIW this means Wireshark master (to become 2.2) will no longer work on
RHEL/CentOS 6 (which has autoconf 2.63).  I don't seem to have an easy
way to check SLES.

If 2.2 is really going to drop support for Gtk+ then it's a moot point
(since the Qt interface won't compile on RHEL 6 either) but I wanted to
point this out just in case.  (There are a lot of RHEL/CentOS 6 users
out there and that will likely continue to be the case for a while.)

(I'm no longer in a position to be too worried about losing support for
RHEL 6 but others may feel differently.)


It's not losing support. It will build and run fine from a tarball or binary package.