Wireshark-dev: Re: [Wireshark-dev] invalid output in pidl generated dcercp-mapi & dercp-nspi di
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Date: Fri, 12 Feb 2016 17:14:34 +0100


On Fri, Feb 12, 2016 at 3:17 PM, Aurélien Aptel <aaptel@xxxxxxxx> wrote:
On Thu, 11 Feb 2016 16:26:16 +0100 Aurélien Aptel <aaptel@xxxxxxxx>
wrote:
> Most generated files are almost identical (slightly altered comments
> and whitespace because pidl wasn't run again) except for
> packet-dcerpc-mapi.[ch] and packet-dcerpc-nsapi.[ch] who differs
> greatly. These new generated files don't compile because they are
> malformed. Sample output:

After sync, pidl generates the exact same (malformed) code so this
problem is not "blocking" the pidl sync. I'll post my changes for review
on both samba and wireshark mailing list (my initial post is still
waiting moderation approval).

Aurélien,
For review (on Wireshark), you need to use directly gerrit : https://wiki.wireshark.org/Development/SubmittingPatches


Cheers
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
Nürnberg)

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe