Wireshark-dev: Re: [Wireshark-dev] wtap.h / struct ieee802_11n & ac presence_flags
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Simon Barber <simon.barber@xxxxxxxxxx>
Date: Thu, 10 Dec 2015 14:39:05 -0800
Pushed as

https://code.wireshark.org/review/12511 Refactor 802.11 radio flags.


On Thu, Sep 24, 2015 at 12:21 PM, Guy Harris <guy@xxxxxxxxxxxx> wrote:

On Sep 24, 2015, at 11:42 AM, Simon Barber <simon.barber@xxxxxxxxxx> wrote:

> I am porting my radiotap only timeline code over to use the new radio dissector, and found the use of the flags aesthetically unpleasing (since I refer to them a lot). Would you object to me converting them to single bit fields, and memsetting the whole union to 0 to clear them?

No, I'm OK with that.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe