Wireshark · Wireshark-dev: Re: [Wireshark-dev] Wireshark Performance

[Evan Huus <eapache@xxxxxxxxx>]

https://code.wireshark.org/review/12389

A mistake in the macro->method conversion caused the addresses to not
actually be added to the hash, leading to hash collision for most
addresses and the extreme slowdown.

On Wed, Dec 2, 2015 at 4:42 PM, Evan Huus <eapache@xxxxxxxxx> wrote:
> Figured it out, the macro and the method are not identical. Patch incoming.
>
> On Wed, Dec 2, 2015 at 4:37 PM, Jim Young <jyoung@xxxxxxx> wrote:
>> My tests point to v2.1.0rc0-228-g4f39c60 on master as the big one in terms of capture file load performance hit, but there is an earlier commit that appears to consistently added one second to  the load of my test file versus head on master-2.0.  I'll start bisect for this smaller one shortly.
>>
>>> C:\Development\wireshark>git bisect log
>>> # bad: [e628c02a78d1af3aa9ae8d707e6e10fe26591598] Update URLs for DDS specifications.
>>> # good: [dae1286270af8cc9f6839e82102fa7433ac7acb4] Qt: Add "Bluetooth" prefix for Bluetooth item in Wireless menu
>>> git bisect start 'e628c02' 'dae1286'
>>> # good: [0f2eb385f0b920cb4117189b9d13e88ae22787eb] x11 generator: Fix struct size with array
>>> git bisect good 0f2eb385f0b920cb4117189b9d13e88ae22787eb
>>> # good: [b7de996684891c4d0584f78241d814de26509f44] RtpAudioStream: Add a cast.
>>> git bisect good b7de996684891c4d0584f78241d814de26509f44
>>> # good: [ae130f114cd61443c8c93e1c9280e027726a0235] 802.1ah: call subdissectors even when we have no tree.
>>> git bisect good ae130f114cd61443c8c93e1c9280e027726a0235
>>> # bad: [d77c1e18ebb9569dcfbe386156d0342944cd3325] NTP timestamps can't be relative.
>>> git bisect bad d77c1e18ebb9569dcfbe386156d0342944cd3325
>>> # bad: [02d56ffa9c540dde3c3a9d1a77bd90f5a3b98962] TDS: Replace use of val_to_str() with VALS()
>>> git bisect bad 02d56ffa9c540dde3c3a9d1a77bd90f5a3b98962
>>> # bad: [3385c2951c7dfecaaf0aad871a0842319d386321] NULL terminate some hf_ arrays used in proto_tree_add_bitmask_xxx calls.
>>> git bisect bad 3385c2951c7dfecaaf0aad871a0842319d386321
>>> # bad: [4f39c603c2f0a2e429afedd18cd5c796bbbf8916] More ADDRESS macro to address function conversions.
>>> git bisect bad 4f39c603c2f0a2e429afedd18cd5c796bbbf8916
>>> # first bad commit: [4f39c603c2f0a2e429afedd18cd5c796bbbf8916] More ADDRESS macro to address function conversions.
>>>
>>> C:\Development\wireshark>git describe
>>> v2.1.0rc0-228-g4f39c60
>>>
>>> C:\Development\wireshark>
>> ___________________________________________________________________________
>> Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives:    https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>>              mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe