Wireshark · Wireshark-dev: Re: [Wireshark-dev] Changes to packet-mip6.c

["Dhananjay Patki (dhpatki)" <dhpatki@xxxxxxxxx>]

Hi Alexis,

Thanks for pointing me to this wiki. It helped. I was able to commit to my local branch and raise a review. https://code.wireshark.org/review/#/c/10565/.

Who will sign up for the review? Is there a sub group that will look info PMIPv6 related dissector changes?

-- 

Regards,

Dhananjay

From: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Reply-To: "alexis.lagoutte@xxxxxxxxx" <alexis.lagoutte@xxxxxxxxx>, Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Date: Friday, 18 September 2015 5:25 pm
To: Developer support list for Wireshark <wireshark-dev@xxxxxxxxxxxxx>
Subject: Re: [Wireshark-dev] Changes to packet-mip6.c

Hi Patki,

You can use also this documentation :
https://wiki.wireshark.org/Development/SubmittingPatches

What git status say ?

i have commit your change on your local branch ?

Regards,

On Fri, Sep 18, 2015 at 1:31 PM, Dhananjay Patki (dhpatki) <dhpatki@xxxxxxxxx> wrote:

Hi,

I have done changes to packet-mip6.c dissector to add support for RFC 7148. I am looking for contributing this code to Wireshark Git repository. I referred to the below URL. However I am getting a clear view of what steps need to be followed.

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html

Could someone please help with how can I go about contributing this diff? I tried the following. But it didn’t work. I am sure I am missing something important.

$ git push ssh://dhpatki@xxxxxxxxxxxxxxxxxx:29418/wireshark HEAD:refs/for/master/mip6-dmnp

Counting objects: 98, done.

Delta compression using up to 8 threads.

Compressing objects: 100% (88/88), done.

Writing objects: 100% (98/98), 45.23 KiB | 0 bytes/s, done.

Total 98 (delta 79), reused 29 (delta 10)

remote: Resolving deltas: 100% (79/79)

remote: Processing changes: refs: 1, done

To ssh://dhpatki@xxxxxxxxxxxxxxxxxx:29418/wireshark

 ! [remote rejected] HEAD -> refs/for/master/mip6-dmnp (no new changes)

error: failed to push some refs to 'ssh://dhpatki@xxxxxxxxxxxxxxxxxx:29418/wireshark'

--

Regards,

Dhananjay

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe