Wireshark-dev: Re: [Wireshark-dev] tvb_captured_length or tvb_reported_length?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Christopher Maynard <Christopher.Maynard@xxxxxxx>
Date: Thu, 3 Sep 2015 13:37:20 +0000 (UTC)
Guy Harris <guy@...> writes:

> On Sep 3, 2015, at 1:09 AM, Robert Cragie <robert.cragie@...> wrote:
> 
> > Thanks for all your responses - much clearer now. I have used what I
think is right for what I am doing and all
> seems OK. On a quick review of all the code, all I would say is that some
of the uses are probably inconsistent
> with what has been said.
> 
> Yes, we know there are some places where
tvb_length()/tvb_captured_length() is being used when it
> shouldn't be.

Robert, if you've identified instances where they are used improperly,
please feel free to report them by opening a bug report at
https://bugs.wireshark.org/bugzilla/, and if you're able, you can even
provide a patch correcting the misuse yourself.  These pages should help
with patch submissions: 

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html
https://wiki.wireshark.org/Development/SubmittingPatches

Thanks.
- Chris