Wireshark · Wireshark-dev: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

[Anders Broman <anders.broman@xxxxxxxxxxxx>]

 

 

From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Alexis La Goutte
Sent: den 31 augusti 2015 09:43
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] MSVC 2015 (VC14) notes/issue

 

 

 

On Sun, Aug 30, 2015 at 11:25 PM, Bill Meier <wmeier@xxxxxxxxxxx> wrote:

On 8/12/2015 12:21 PM, Bill Meier wrote:

2. I had to disable building with geoip because:

#error:  Macro definition of snprintf conflicts with Stan
dard Library function declaration (compiling source file packet-ip.c)

A little digging finds that the Windows Wireshark version of the GeoIP library(1.5.2) is a bit old; The current version (on GitHub [1]) is 1.6.6 and has had various fixes made since 1.5.2.

I also note that the 1.6.6 GeoIP.h no longer has the macro definition for snprintf so the MSVC2015 GeoIP compile problem obviously won't occur using the latest version.

I don't really know to create the GeoIP libraries (and couldn't easily do a 64 bit version anyway) so I'll leave this as a ToDo for others (Gerald ?).

(Obviously there's no urgency for this).

[1] https://github.com/maxmind/geoip-api-c

 

May be directly move to GeoIP 2 ?
https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10658

 

I think the code is available from here:

https://github.com/maxmind/libmaxminddb

Regards

Anders

 

 

Cheers,

Bill



___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe