Wireshark-dev: Re: [Wireshark-dev] Qt related menu issues on Mac OS X (bug 10890, etc)
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Luke Mewburn <luke@xxxxxxxxxxx>
Date: Fri, 24 Jul 2015 10:57:43 +1000
On Thu, Jul 23, 2015 at 02:45:57PM -0700, Guy Harris wrote:
  | 
  | On Jul 22, 2015, at 8:20 PM, Luke Mewburn <luke@xxxxxxxxxxx> wrote:
  | 
  | > I suspect that this Qt bug (QTBUG-34160) may not be easily worked-around
  | > within Wireshark without radical menu reorganisation.
  | 
  | I'm not sure how radical
  | 
  | 	https://code.wireshark.org/review/#/c/9760/
  | 
  | is, but do the issues from bug 10890 remain after that change?

Less radical than I thought. Then again, I'm not a UI programmer
and it shows :)

Gerald's changes appear to resolve the Qt warnings, although there's a
minor issue in where the Copy menu is attached, but I've noted that in a
comment on that review.




  | As for Copy Bytes, that's just not implemented yet, according to
  | Alexis La Goutte:
  | 
  | 	https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=10890#c12

Ok.


  | > I tried building against 5.5.0 from qt.io
  | > (qt-opensource-mac-x64-clang-5.5.0.dmg)
  | > after disabling the homebrew version in /usr/local,
  | > but it's been a bit of a hassle to get it to build and link.
  | 
  | Any hassle other than having to fix the .pc files?

Probably not, although I haven't done much in that space except
working around borken .pc files on various platforms in the past.


  | > I think the pkg-config .pc files that are shipped with the qt.io are
  | > broken (that's an Qt5.5.0 upstream problem).
  | 
  | To be particular, it's problems (plural) QTBUG-35256:
  | 
  | 	https://bugreports.qt.io/browse/QTBUG-35256
  | 
  | which predates Qt 5.5.0 and QTBUG-47162:
  | 
  | 	https://bugreports.qt.io/browse/QTBUG-47162
  | 
  | which is new in 5.5.0.

Ah, I see that you're already on ahead of me on this!


  | > I had to manually edit Makefile and ui/qt/Makefile and
  | > add -F and various -I to CXXFLAGS, and fix incorrectly escaped
  | > -framework\ FOO (remove the \ between "-framework" and the argument).
  | 
  | The macosx-setup.sh script not only downloads the Qt image and runs
  | its installer, it runs an editing script afterwards that fixes those
  | problem.
  | 
  | If you're building Wireshark from source on OS X, the best way to
  | get the relevant libraries installed is with that script, which will
  | do the downloading, patching as necessary, compiling if it's a
  | source rather than a binary installation, and installation for you.

I appreciate the intention of such setup scripts. Generally I haven't
needed them (until now!).  I'm a little leery of stuff that's going to
potentially fiddle with my /usr and /usr/local, especially when I already
have homebrew already (overstepping its bounds) adding stuff under
/usr/local.

If I end up needing to use the script and I get enthusiastic enough, I
may look at enhancing the script to allow override of where the files
get installed (e.g. in a directory under ~) instead of installing into
/usr and /usr/local, although I suspect the various .dmg installers for
some of the dependencies already do that anyway and that may be harder
to work around.

Alternatively, I could just document how I've got it working using
homebrew, at least for my own development test builds rather than
for production release builds.


regards,
Luke.

Attachment: pgpCk_ccIMe14.pgp
Description: PGP signature