Wireshark · Wireshark-dev: [Wireshark-dev] Windows x64 buildbot warnings

[Graham Bloice <graham.bloice@xxxxxxxxxxxxx>]

The buildbot is generating some warnings in the template instantiations of the sort:

    73>C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3050): warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (C:\buildbot\wireshark\wireshark-master-64\win7x64\build\ui\qt\wireshark_application.cpp) [C:\buildbot\wireshark\wireshark-master-64\win7x64\build\cmbuild\ui\qt\qtui.vcxproj]
                 C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3065) : see reference to function template instantiation 'void std::_Median<_RanIt,bool(__cdecl *)(const QAction *,const QAction *)>(_RanIt,_RanIt,_RanIt,_Pr)' being compiled
                 with
                 [
                     _RanIt=QList<QAction *>::iterator
         ,            _Pr=bool (__cdecl *)(const QAction *,const QAction *)
                 ]
                 C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3127) : see reference to function template instantiation 'std::pair<_RanIt,_RanIt> std::_Unguarded_partition<_RanIt,bool(__cdecl *)(const QAction *,const QAction *)>(_RanIt,_RanIt,_Pr)' being compiled
                 with
                 [
                     _RanIt=QList<QAction *>::iterator
         ,            _Pr=bool (__cdecl *)(const QAction *,const QAction *)
                 ]
                 C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3157) : see reference to function template instantiation 'void std::_Sort<_Iter,int,bool(__cdecl *)(const QAction *,const QAction *)>(_RanIt,_RanIt,_Diff,_Pr)' being compiled
                 with
                 [
                     _Iter=QList<QAction *>::iterator
         ,            _RanIt=QList<QAction *>::iterator
         ,            _Diff=int
         ,            _Pr=bool (__cdecl *)(const QAction *,const QAction *)
                 ]
                 C:\buildbot\wireshark\wireshark-master-64\win7x64\build\ui\qt\wireshark_application.cpp(591) : see reference to function template instantiation 'void std::sort<QList<QAction *>::iterator,bool(__cdecl *)(const QAction *,const QAction *)>(_RanIt,_RanIt,_Pr)' being compiled
                 with
                 [
                     _RanIt=QList<QAction *>::iterator
         ,            _Pr=bool (__cdecl *)(const QAction *,const QAction *)
                 ]
    73>C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3051): warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (C:\buildbot\wireshark\wireshark-master-64\win7x64\build\ui\qt\wireshark_application.cpp) [C:\buildbot\wireshark\wireshark-master-64\win7x64\build\cmbuild\ui\qt\qtui.vcxproj]
    73>C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3052): warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (C:\buildbot\wireshark\wireshark-master-64\win7x64\build\ui\qt\wireshark_application.cpp) [C:\buildbot\wireshark\wireshark-master-64\win7x64\build\cmbuild\ui\qt\qtui.vcxproj]
    73>C:\Program Files (x86)\Microsoft Visual Studio 12.0\VC\include\algorithm(3053): warning C4267: 'argument' : conversion from 'size_t' to 'int', possible loss of data (C:\buildbot\wireshark\wireshark-master-64\win7x64\build\ui\qt\wireshark_application.cpp) [C:\buildbot\wireshark\wireshark-master-64\win7x64\build\cmbuild\ui\qt\qtui.vcxproj]

I can't replicate this in an x64 build, but I'm using Qt 5.4 and the buildbot is using 5.3, I wonder if this is a QT issue fixed by the later version?

--

Graham Bloice