Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master b5b3a6b: ISAKMP: Fix Dead Store (Dead assignement/Dea

[Pascal Quantin <pascal.quantin@xxxxxxxxx>]

Hi Martin,

2015-06-06 16:59 GMT+02:00 Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>:

This is only a dead store if HAVE_LIBGCRYPT is not defined...

Fixed in gbe701f6.

Pascal.

Martin

On Sat, Jun 6, 2015 at 12:52 PM, Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx> wrote:

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b5b3a6b9af2c8f72342cac51207346011148404d
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

b5b3a6b by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    ISAKMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang

    Change-Id: I06d09d5d0d54c96e18d9b423999cb309559612dd
    Reviewed-on: https://code.wireshark.org/review/8784
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>


Actions performed:

    from  04f0847   IEEE 802.11: Add a option for disable FCS check
    adds  b5b3a6b   ISAKMP: Fix Dead Store (Dead assignement/Dead increment) warning found by Clang


Summary of changes:
 epan/dissectors/packet-isakmp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe