Wireshark-dev: Re: [Wireshark-dev] Qt: Convert ProtoTree from QTreeWidget to Model/View
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Mon, 09 Mar 2015 11:44:21 -0700
On 3/9/15 7:56 AM, Peter Wu wrote:
> Hi,
> 
> I have recently discovered that the Qt UI gets in an inconsistent state
> (leading to crashes) whenever a packet dialog is open and packets are
> re-dissected. This is reported at
> https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=11044
> 
> Before proceeding to a reimplementation attempt using Model/View, I
> would like to solicit for some feedback. Was the QTreeWidget choice done
> consciously? Do you foresee issues with sharing field items via the same
> model? Is someone already working on this?

A QTreeWidget was chosen lazily, i.e. it did the job at the time. A custom
model might make more sense given that we have a large limit on the number
of tree items (MAX_TREE_ITEMS = 1e6).

Having independent models lets each packet dialog persist across files.
Would a shared model still allow that?