Wireshark-dev: Re: [Wireshark-dev] Latest build modifies files?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Guy Harris <guy@xxxxxxxxxxxx>
Date: Sat, 7 Mar 2015 13:05:59 -0800
On Mar 7, 2015, at 12:59 PM, Richard Sharpe <realrichardsharpe@xxxxxxxxx> wrote:

> Hi folks,
> 
> After my most recent build I noticed this:
> 
> # On branch master
> # Your branch is ahead of 'origin/master' by 1 commit.
> #   (use "git push" to publish your local commits)
> #
> # Changes not staged for commit:
> #   (use "git add <file>..." to update what will be committed)
> #   (use "git checkout -- <file>..." to discard changes in working directory)
> #
> # modified:   ui/qt/wireshark_de.qm
> # modified:   ui/qt/wireshark_it.qm
> # modified:   ui/qt/wireshark_ja_JP.qm
> # modified:   ui/qt/wireshark_pl.qm
> # modified:   ui/qt/wireshark_zh_CN.qm
> #
> 
> I did not touch those files and it seems a bit rude of the build to modify them.

That was done in

	https://code.wireshark.org/review/7460/

and I've already added a comment there noting that either we should *not* have the .qm files checked into Git and *require* that you have the tools necessary to build them if you're going to build from Git or have them checked into Git and *not* build them as part of the build process.