One more hint: if push patch as draft then add reviewer, because draft
is invisible for anyone (expect author and reviewers)
Alternative command(s) to send to gerrit:
git push origin HEAD:refs/drafts/master
git push origin HEAD:refs/publish/master
By the way: I vote for adding expert info. Sometimes there are
undecoded fields with info like that "Undecoded if you want that ask
developers to add" :)
On 5 February 2015 at 19:29, Evan Huus <eapache@xxxxxxxxx> wrote:
> Please just upload it Gerrit - it's much easier to review there. You
> can upload it as a draft (pass the -D flag to git-review) if you want
> to avoid cluttering up the main review list yet.
>
> On Thu, Feb 5, 2015 at 11:49 AM, Dario Lombardo
> <dario.lombardo.ml@xxxxxxxxx> wrote:
>> Evan,
>> please find attached a patch that implements what I was trying to do. I'd
>> like to share it here with you and other devels in order to understand if it
>> goes in the right direction and maybe to open discussions on it. If it seems
>> good, I'll move it to gerrit for code review.
>>
>> To test it, simply comment any proto_tree_add_item() from a dissector of
>> your choice, and open a packet with wireshark or with tshark -V.
>>
>> Comments are welcome.
>> Dario.
>>
>> On Thu, Feb 5, 2015 at 1:41 PM, Dario Lombardo <dario.lombardo.ml@xxxxxxxxx>
>> wrote:
>>>
>>> On Thu, Feb 5, 2015 at 1:19 PM, Evan Huus <eapache@xxxxxxxxx> wrote:
>>>>
>>>> I believe g_log and friends go to standard out, but maybe not on all
>>>> platforms. An expert info under conditional compilation would probably
>>>> be enough though, I hadn't thought of that.
>>>
>>>
>>> Another question. I've found a promising point to put the check
>>> (packet.c:call_dissector_with_data()). This function is called many times (I
>>> can count 4 times per packet). Sometimes when tree is open, sometimes when
>>> it's closed. How can I navigate (and check) the tree only and only if it's
>>> open?
>>> Only in this case I can check if there are undecoded bytes.
>>
>>
>>
>> ___________________________________________________________________________
>> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
>> Archives: http://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
> ___________________________________________________________________________
> Sent via: Wireshark-dev mailing list <wireshark-dev@xxxxxxxxxxxxx>
> Archives: http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
> mailto:wireshark-dev-request@xxxxxxxxxxxxx?subject=unsubscribe
--
Pozdrawiam / Best regards
-------------------------------------------------------------------------------------------------------------
Michał Łabędzki, Software Engineer
Tieto Corporation
Product Development Services
http://www.tieto.com / http://www.tieto.pl
---
ASCII: Michal Labedzki
location: Swobodna 1 Street, 50-088 Wrocław, Poland
room: 5.01 (desk next to 5.08)
---
Please note: The information contained in this message may be legally
privileged and confidential and protected from disclosure. If the
reader of this message is not the intended recipient, you are hereby
notified that any unauthorised use, distribution or copying of this
communication is strictly prohibited. If you have received this
communication in error, please notify us immediately by replying to
the message and deleting it from your computer. Thank You.
---
Please consider the environment before printing this e-mail.
---
Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w
Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym
Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego
Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON:
812023656. Kapitał zakładowy: 4 271500 PLN
