Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master 6e6a129: CMake: Set an output dir
From: Evan Huus <eapache@xxxxxxxxx>
Date: Tue, 20 Jan 2015 11:21:31 -0500
Plugins still aren't loaded on my out-of-tree MacOSX build, but I'm
interested in getting this working (not that I really know how)...

On Tue, Jan 20, 2015 at 11:12 AM, Wireshark code review
<code-review-do-not-reply@xxxxxxxxxxxxx> wrote:
> URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e6a1291d0b36fe97d0f684e1abdfe546aaeae7f
> Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
> Changed: branch: master
> Repository: wireshark
>
> Commits:
>
> 6e6a129 by Gerald Combs (gerald@xxxxxxxx):
>
>     CMake: Set an output directory for plugins.
>
>     Redefine PLUGIN_DIR similar to DATAFILE_DIR and use it on all
>     platforms. Add WiresharkPlugin.cmake so that we can start defining common
>     macros for plugins/*/CMakeLists.txt. Load plugins in out-of-tree builds.
>
>     Change-Id: I8c1359ed3cf8a71788b8320ff89dfe2d3969def2
>     Reviewed-on: https://code.wireshark.org/review/6640
>     Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
>
>
> Actions performed:
>
>     from  af3924a   HTTP2: Add HPACK decode to test suite
>     adds  6e6a129   CMake: Set an output directory for plugins.
>
>
> Summary of changes:
>  CMakeLists.txt                      |   89 ++++++++++++++++++++---------------
>  Makefile.am                         |    2 +
>  cmake/modules/WiresharkPlugin.cmake |   61 ++++++++++++++++++++++++
>  plugins/docsis/CMakeLists.txt       |   43 ++---------------
>  plugins/ethercat/CMakeLists.txt     |   43 ++---------------
>  plugins/gryphon/CMakeLists.txt      |   43 ++---------------
>  plugins/irda/CMakeLists.txt         |   43 ++---------------
>  plugins/m2m/CMakeLists.txt          |   43 ++---------------
>  plugins/mate/CMakeLists.txt         |   43 ++---------------
>  plugins/opcua/CMakeLists.txt        |   42 ++---------------
>  plugins/profinet/CMakeLists.txt     |   43 ++---------------
>  plugins/stats_tree/CMakeLists.txt   |   47 ++----------------
>  plugins/tpg/CMakeLists.txt          |   25 +++-------
>  plugins/unistim/CMakeLists.txt      |   42 ++---------------
>  plugins/wimax/CMakeLists.txt        |   43 ++---------------
>  plugins/wimaxasncp/CMakeLists.txt   |   43 ++---------------
>  plugins/wimaxmacphy/CMakeLists.txt  |   43 ++---------------
>  wsutil/plugins.c                    |   10 ++--
>  18 files changed, 168 insertions(+), 580 deletions(-)
>  create mode 100644 cmake/modules/WiresharkPlugin.cmake
> ___________________________________________________________________________
> Sent via:    Wireshark-commits mailing list <wireshark-commits@xxxxxxxxxxxxx>
> Archives:    http://www.wireshark.org/lists/wireshark-commits
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
>              mailto:wireshark-commits-request@xxxxxxxxxxxxx?subject=unsubscribe