Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] master e75dd98: NetFlow: Assign instead
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jeff Morriss <jeff.morriss.ws@xxxxxxxxx>
Date: Thu, 15 Jan 2015 14:32:43 -0500
On 01/15/15 14:04, Wireshark code review wrote:

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e75dd98b3d9a8b4177461c8dd2c6e547b5fe5924
Submitter: Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

e75dd98 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

     NetFlow: Assign instead of compare (CID 1262419 & 1262420)
That's one of the problems with "too many" parenthesis. GCC would have caught this were it not for the parenthesis around the condition: 


../../../epan/dissectors/packet-netflow.c: In function 'dissect_v9_v10_pdu_data':
../../../epan/dissectors/packet-netflow.c:3009:17: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
                 else if (pen_type = 182 || (ip_protocol == IP_PROTO_TCP)) {